Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal server bootstrap for query frontend #7328

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Fix internal server bootstrap for query frontend #7328

merged 2 commits into from
Oct 5, 2022

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Oct 4, 2022

What this PR does / why we need it:
The following PR adds a fix for setting up the internal server module for the query-frontend-tripperware instead for the query-frontend. Solves issue as:

level=info ts=2022-10-04T12:14:37.375681075Z caller=main.go:103 msg="Starting Loki" version="(version=main-ec0bf70, branch=main, revision=ec0bf7004)"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x2f8 pc=0x1d034d3]

goroutine 1 [running]:
github.com/grafana/loki/pkg/loki.(*Loki).initQueryFrontend(0xc000c10000)
        /src/loki/pkg/loki/modules.go:738 +0x5b3
github.com/grafana/dskit/modules.(*Manager).initModule(0xc00000c330, {0x7ffd008d08b3, 0xe}, 0x1?, 0xc000c0e600?)
        /src/loki/vendor/github.com/grafana/dskit/modules/modules.go:120 +0x224
github.com/grafana/dskit/modules.(*Manager).InitModuleServices(0x82d4b4?, {0xc0001b2ce0, 0x1, 0xc0001b3870?})
        /src/loki/vendor/github.com/grafana/dskit/modules/modules.go:92 +0x10c
github.com/grafana/loki/pkg/loki.(*Loki).Run(0xc000c10000, {0xc000c03ac0?})
        /src/loki/pkg/loki/loki.go:350 +0x56
main.main()
        /src/loki/cmd/loki/main.go:105 +0xdb2

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@periklis periklis requested a review from a team as a code owner October 4, 2022 12:53
@periklis periklis self-assigned this Oct 4, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@periklis periklis mentioned this pull request Oct 4, 2022
Merged
4 tasks
dannykopping
dannykopping approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dannykopping dannykopping merged commit e941974 into grafana:main Oct 5, 2022
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
@periklis @lxwzy
Fix internal server bootstrap for query frontend (grafana#7328)
29a662d 
Adds a fix for setting up the internal server module
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
@periklis @changhyuni
Fix internal server bootstrap for query frontend (grafana#7328)
e54c14a 
Adds a fix for setting up the internal server module
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
@periklis @Abuelodelanada
Fix internal server bootstrap for query frontend (grafana#7328)
fceec57 
Adds a fix for setting up the internal server module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@periklis periklis

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@periklis @grafanabot @dannykopping